Skip to content

Conversation

@kash2104
Copy link
Contributor

Why are these changes needed?

This commit updates the docker base image from node:18-alpine to node:24-alpine in kuberay dashboard.

Related issue number

Closes #4165

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Collaborator

@CheyuWu CheyuWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help.
LGTM

@CheyuWu
Copy link
Collaborator

CheyuWu commented Nov 16, 2025

nit: Could you change the title to something like

[Dockerfile] [KubeRay Dashboard] XXXXX

@kash2104 kash2104 changed the title enhancement: Update docker base image. [Dockerfile] [KubeRay Dashboard] Update docker base image. Nov 16, 2025
@kash2104
Copy link
Contributor Author

@CheyuWu Have changed the title as suggested.

@CheyuWu
Copy link
Collaborator

CheyuWu commented Nov 27, 2025

@rueian Could you please take a look?

@andrewsykim
Copy link
Member

LGTM, but were you able to test the dashboard works with the new image?

@kash2104
Copy link
Contributor Author

kash2104 commented Nov 29, 2025

LGTM, but were you able to test the dashboard works with the new image?

Yes, I have successfully checked and tested dashboard working with the new image.

@rueian rueian merged commit 04530dd into ray-project:master Nov 29, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dockerfile] [KubeRay Dashboard] Update Docker base image from node:18-alpine to node:24-alpine (Node 18 EOL)

5 participants